Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validator to Text type sign-up list field #1700

Merged

Conversation

tomudding
Copy link
Member

@tomudding tomudding commented Sep 8, 2023

Adds NotEmpty validator and a StringTrim filter to make sure the field value is never the empty string.

image

This closes GH-1642 by changing the only field type that did not have built-in validation.

Adds `NotEmpty` validator and a `StringTrim` filter to make sure the
field value is never the empty string.
@tomudding tomudding force-pushed the fix/text-field-not-required-sign-ups branch from 5d9feb9 to 0f862b1 Compare September 9, 2023 16:18
@tomudding tomudding merged commit 3b94070 into GEWIS:main Sep 9, 2023
github-actions bot added a commit that referenced this pull request Sep 9, 2023
Tom Udding: Merge pull request #1700 from tomudding/fix/text-field-not-required-sign-ups

Add validator to `Text` type sign-up list field

Co-authored-by: tomudding <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow setting sign-up list options as required
1 participant